[WFCORE-7134] Remove ModuleIdentifier use in the elytron subsystem #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Thanks @soul2zimate.
All of these cases involve handling external input so we need to ensure the module names are canonical.
elytron/src/main/java/org/wildfly/extension/elytron/DirContextDefinition.java
Outdated
Show resolved
Hide resolved
elytron/src/main/java/org/wildfly/extension/elytron/ClassLoadingAttributeDefinitions.java
Outdated
Show resolved
Hide resolved
elytron/src/main/java/org/wildfly/extension/elytron/PermissionMapperDefinitions.java
Show resolved
Hide resolved
soul2zimate
force-pushed
the
WFCORE-7134-main
branch
from
44dbace to
88f67ae
Compare
|
Core -> Full Integration Build 14539 outcome was UNKNOWN using a merge of 88f67ae |
|
Core -> Full Integration Build 14236 outcome was UNKNOWN using a merge of 88f67ae |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/retest |
yersan
approved these changes
Jan 20, 2025
yersan
added
the
ready-for-merge
|
Thanks @soul2zimate @bstansberry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-7134
[WFCORE-7134] Remove
ModuleIdentifieruse in the elytron subsystem