feat: fix the use of vite.base in Astro Dev Server

[chaegumi]

Changes

Resolve this issue

#7520

The problem solved by this PR is that after setting the base, when pnpm run dev, the src address of the generated script type="module" tag is incorrect,

export default defineConfig({
  base: '/theme141',
})

<script type="module" src="/@vite/client"></script>
<script type="module" src="/@id/astro:scripts/page.js"></script>
<script type="module" src="/node_modules/"></script>

It still starts with/node_modules.

The expectation should start with the value of base,

<script type="module" src="/theme141/@vite/client"></script>
<script type="module" src="/theme141/@id/astro:scripts/page.js"></script>
<script type="module" src="/theme141/node_modules/"></script>

I found that modifying the base of the root node of astro.config.mjs does not work. I need to set vite.base so that it can be parsed correctly.

export default defineConfig({
  // base: '/ theme141',
  vite: {
    base: '/theme141'
  }
})

For example:

When using 127.0.0.1 or localhost, the generated resources can be accessed normally even if the address is incorrect.

But when I resolve a domain name locally

C:\Windows\System32\drivers\etc\hosts
127.0.0.1 example.local

Then when I use example.local/theme141 to access it, there will be a path error. Not setting the root base, only setting vite.base, and then cooperating with my modifications, can make the program run perfectly

Testing

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: 0930a6c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[chaegumi]

#7520 (comment)

[codspeed-hq]

CodSpeed Performance Report

Merging #13003 will not alter performance

_{Comparing chaegumi:nginx-proxy_pass-dev-mode (0930a6c) with main (f576519)}

Summary

✅ 6 untouched benchmarks

[github-actions]

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

[ascorbic]

Thanks for your contribution. I've left a few comments, but before you do more we need a much more detailed description in the PR of what exactly it is trying to do. need more info to see if this is something that needs doing. If this is just something for nginx then it's not something we're likely to add - it needs to show what problem it is solving, and how. It will also need tests, proabably ones that fail before your PR is added. I

[ascorbic]

You already have this as viteConfig below. We also can't have any

[ascorbic]

This needs a full description of what this PR does, phrased as if it's prefixed with "This PR..."

[chaegumi]

The problem solved by this PR is that after setting the base, when pnpm run dev, the src address of the generated script type="module" tag is incorrect,

export default defineConfig({
  base: '/theme141',
})

<script type="module" src="/@vite/client"></script>
<script type="module" src="/@id/astro:scripts/page.js"></script>
<script type="module" src="/node_modules/"></script>

It still starts with/node_modules.

The expectation should start with the value of base,

<script type="module" src="/theme141/@vite/client"></script>
<script type="module" src="/theme141/@id/astro:scripts/page.js"></script>
<script type="module" src="/theme141/node_modules/"></script>

I found that modifying the base of the root node of astro.config.mjs does not work. I need to set vite.base so that it can be parsed correctly.

export default defineConfig({
  // base: '/ theme141',
  vite: {
    base: '/theme141'
  }
})

For example:

When using 127.0.0.1 or localhost, the generated resources can be accessed normally even if the address is incorrect.

But when I resolve a domain name locally

C:\Windows\System32\drivers\etc\hosts
127.0.0.1 example.local

Then when I use example.local/theme141 to access it, there will be a path error. Not setting the root base, only setting vite.base, and then cooperating with my modifications, can make the program run perfectly

[ematipico]

Thank you @chaegumi for your comment. Please update the title and description of the PR to better reflect what you're trying to solve. Also, add some tests