feat: add experimentalDisableStreaming to react integration (#1) #13036
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add experimentalDisableStreaming to react integration * chore: commit save point * chore: commit save point
🦋 Changeset detectedLatest commit: f946f07 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: react
|
Conceptually this makes sense as an option, and needed for most CSS-in-JS usage. |
Co-authored-by: Florian Lefebvre <[email protected]>
ascorbic
reviewed
Jan 22, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@astrojs/react": patch | |||
There was a problem hiding this comment.
This adds a feature, so would be a minor
| "@astrojs/react": patch | ||
| --- | ||
|
|
||
| feat: add experimentalDisableStreaming to react integration (#1) |
There was a problem hiding this comment.
Suggested change
| feat: add experimentalDisableStreaming to react integration (#1) | |
| Add support for disabling streaming in React integration |
There was a problem hiding this comment.
Suggested change
| feat: add experimentalDisableStreaming to react integration (#1) | |
| Adds experimental support for disabling streaming |
It would be nice to also show a code snippet. This will require a docs PR as well
| @@ -14,6 +14,10 @@ export type ReactIntegrationOptions = Pick< | |||
| 'include' | 'exclude' | 'babel' | |||
| > & { | |||
| experimentalReactChildren?: boolean; | |||
| /** | |||
| * Disable streaming support for React components in order to support libraries that are not compatible with streaming like Stitches.js | |||
There was a problem hiding this comment.
Suggested change
| * Disable streaming support for React components in order to support libraries that are not compatible with streaming like Stitches.js | |
| * Disable streaming in React components |
Comment on lines
+33
to
+36
| function optionsPlugin( | ||
| experimentalReactChildren: boolean, | ||
| experimentalDisableStreaming: boolean | ||
| ): vite.Plugin { |
There was a problem hiding this comment.
Now we're adding more options it's probably best to make this an options object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request introduces a new feature to the React integration by adding an option to disable streaming support. This feature aims to support libraries that are not compatible with streaming, such as Stitches.js. The most important changes include updates to the configuration options and rendering logic.
Testing
Docs