fix: first tab being rendered when onSwitchToTab and a custom current…

…TabIndex is set (#7922)
wix · Oct 15, 2024 · 985a827 · 985a827
1 parent 8c64969
commit 985a827
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/lib/ios/RNNBottomTabsController.m b/lib/ios/RNNBottomTabsController.m
@@ -29,6 +29,11 @@ - (instancetype)initWithLayoutInfo:(RNNLayoutInfo *)layoutInfo
     _bottomTabPresenter = bottomTabPresenter;
     _dotIndicatorPresenter = dotIndicatorPresenter;
 
+    if ([options.bottomTabs.currentTabIndex hasValue]) {
+        _currentTabIndex = [options.bottomTabs.currentTabIndex get];
+        _previousTabIndex = _currentTabIndex;
+    }
+
     self = [super initWithLayoutInfo:layoutInfo
                              creator:creator
                              options:options

diff --git a/playground/ios/NavigationTests/RNNCommandsHandlerTest.m b/playground/ios/NavigationTests/RNNCommandsHandlerTest.m
@@ -521,6 +521,40 @@ - (void)testSetRoot_withBottomTabsAttachModeOnSwitchToTab {
     XCTAssertTrue(_vc2.isViewLoaded);
 }
 
+- (void)testSetRoot_withBottomTabsAttachModeOnSwitchToTabWithCustomIndex {
+    [self.uut setReadyToReceiveCommands:true];
+    RNNNavigationOptions *options = [RNNNavigationOptions emptyOptions];
+    options.bottomTabs.tabsAttachMode =
+        [[BottomTabsAttachMode alloc] initWithValue:@"onSwitchToTab"];
+    options.animations.setRoot.waitForRender = [[Bool alloc] initWithBOOL:YES];
+    options.bottomTabs.currentTabIndex = [IntNumber withValue:@1];
+
+    BottomTabsBaseAttacher *attacher =
+        [[[BottomTabsAttachModeFactory alloc] initWithDefaultOptions:nil] fromOptions:options];
+    RNNBottomTabsController *tabBarController =
+        [[RNNBottomTabsController alloc] initWithLayoutInfo:nil
+                                                    creator:nil
+                                                    options:options
+                                             defaultOptions:[RNNNavigationOptions emptyOptions]
+                                                  presenter:[RNNBasePresenter new]
+                                         bottomTabPresenter:nil
+                                      dotIndicatorPresenter:nil
+                                               eventEmitter:_eventEmmiter
+                                       childViewControllers:@[ _vc1, _vc2 ]
+                                         bottomTabsAttacher:attacher];
+    [tabBarController viewWillAppear:YES];
+    OCMStub([self.controllerFactory createLayout:[OCMArg any]]).andReturn(tabBarController);
+
+    [self.uut setRoot:@{}
+            commandId:@""
+           completion:^(NSString *componentId){
+           }];
+    XCTAssertFalse(_vc1.isViewLoaded);
+    XCTAssertTrue(_vc2.isViewLoaded);
+    [tabBarController setSelectedIndex:0];
+    XCTAssertTrue(_vc1.isViewLoaded);
+}
+
 - (void)testSetRoot_withBottomTabsAttachModeAfterInitialTab {
     [self.uut setReadyToReceiveCommands:true];
     RNNNavigationOptions *options = [RNNNavigationOptions emptyOptions];