infra: introduce and use .nvmrc

setup-node automatically uses it now, instead of duplicating that number to the test script
wixplosives · Dec 31, 2024 · fc7dcd5 · fc7dcd5
1 parent cf4bc89
commit fc7dcd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -2,19 +2,17 @@ name: tests
 on: [push, pull_request]
 jobs:
   tests:
-    name: node ${{ matrix.node-version }} / ${{ matrix.os }}
+    name: ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        node-version: [20]
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version-file: ".nvmrc"
           cache: npm
       - run: npm ci
       - run: npm test
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+20