Bring in support for MAXQ1065 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anhu
commented
Jan 10, 2025
•
anhu
commented
- support for committing certificate into MAXQ
- use the specified devId that is saved in the slot or session
- support for committing certificate into MAXQ
- use the specified devId that is saved in the slot or session
NOTE: requires wolfpkcs11/port/maxim directory be created and MXQ_API header
files be copied in there.
|
NOTE: requires wolfpkcs11/port/maxim directory be created and MXQ_API header files be copied in there. This would be done by scripts in the MAXQ10xx SDK. |
SparkiDev
requested changes
Jan 13, 2025
| @@ -2621,7 +2621,7 @@ CK_RV C_DigestFinal(CK_SESSION_HANDLE hSession, CK_BYTE_PTR pDigest, | |||
| CK_RV C_SignInit(CK_SESSION_HANDLE hSession, CK_MECHANISM_PTR pMechanism, | |||
| CK_OBJECT_HANDLE hKey) | |||
| { | |||
| int ret; | |||
| int ret = 0; | |||
There was a problem hiding this comment.
Shouldn't need this change.
| WP11_Session_SetOpInitialized(session, init); | ||
|
|
||
| return CKR_OK; | ||
| } else |
| if (ret != 0) | ||
| #ifdef WOLFSSL_MAXQ10XX_CRYPTO | ||
| if ((ret != 0) && (hKey == 0) && (pMechanism->mechanism == CKM_ECDSA)) { | ||
| if (pMechanism->pParameter != NULL || pMechanism->ulParameterLen != 0) { |
There was a problem hiding this comment.
Can we check for devId being set?
dgarske
requested changes
Jan 21, 2025
| @@ -1697,6 +1706,270 @@ static int wp11_Object_Load_Cert(WP11_Object* object, int tokenId, int objId) | |||
| return ret; | |||
| } | |||
|
|
|||
| #ifdef WOLFSSL_MAXQ10XX_CRYPTO | |||
| #ifdef MAXQ10XX_PRODUCTION_KEY | |||
There was a problem hiding this comment.
Please add a section in the documentation for MAXQ and the use of MAXQ10XX_PRODUCTION_KEY. Thank you
| #include "maxq10xx_key.h" | ||
| #else | ||
| /* TEST KEY. This must be changed for production environments!! */ | ||
| static mxq_u1 KeyPairImport[] = { |
| DecodedCert decodedCert; | ||
| byte *certBody = NULL; | ||
|
|
||
| mxq_u1 signature[256]; |
There was a problem hiding this comment.
Avoid hard coded signature size, please use macro if possible. Same for 32 and 2048 below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.