snyk-cli/1.1295.2 package update #40479
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![octo-sts[bot]](https://avatars.githubusercontent.com/in/801323?s=60&v=4){kind=small}
Contributor
octo-sts
bot
commented
Jan 24, 2025
octo-sts
bot
commented
Signed-off-by: wolfi-bot <[email protected]>
octo-sts
bot
added
request-version-update
Signed-off-by: Dentrax <[email protected]>
luhring
reviewed
Jan 25, 2025
There was a problem hiding this comment.
It looks like this build config is using make instead of go/build, which means our automation won't remember that the modroot should be ./cliv2, which means we'll continue to get PRs that fail CI.
Could we fix this file once and for all, to use go/build? Or is that too difficult in this case?
Signed-off-by: Debasish Biswas <[email protected]>
|
@luhring it seems using go/build is not that simple in this package, there are multiple npx builds, which is making things complicated. |
Thanks for looking into it! So this is probably a sign that we need a better way to signal the modroot than just relying on |
luhring
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.