Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yunikorn-web/1.6.1 package update #40488

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 24, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 24, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 24, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the build log, I'll analyze and provide specific fixes:

• Detected Error: The build log shows successful dependency installation but fails during the build phase, suggesting a runtime execution error in the pipeline.

• Error Category: Build Configuration

• Failure Point: The pipeline step that runs pnpm i and pnpm build:prod

• Root Cause Analysis: The build environment is set up correctly with all dependencies, but the Angular build process likely needs additional configuration for the production build.

• Suggested Fix:

  1. Add a pre-build step to configure Node.js memory limits:
  - runs: |
      export NODE_OPTIONS="--max-old-space-size=4096"
      mkdir -p ${{targets.contextdir}}/usr/share/yunikorn-web/html
      PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 pnpm i
      pnpm build:prod
      cp -r dist/yunikorn-web/* ${{targets.contextdir}}/usr/share/yunikorn-web/html
  1. Add build caching configuration:
environment:
  contents:
    packages:
      - node-gyp
      - nodejs-18
      - npm
      - pnpm
      - python3
  environment:
    PNPM_HOME: /tmp/.pnpm-store

• Explanation: Angular production builds can be memory-intensive. Setting NODE_OPTIONS increases the available memory for the Node.js process. The PNPM_HOME configuration ensures proper dependency caching.

• Additional Notes:

  • The patch file 0001-increase-the-budget.patch suggests there might be bundle size issues
  • Consider adding --no-frozen-lockfile to pnpm install if version resolution issues occur
  • The build environment has all necessary dependencies installed

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 24, 2025
@OddBloke OddBloke self-assigned this Jan 24, 2025
@OddBloke OddBloke force-pushed the wolfictl-440fe6ac-5c6d-4454-88ad-02cae7feec24 branch from c064523 to 8f72898 Compare January 24, 2025 22:55
@OddBloke OddBloke enabled auto-merge January 24, 2025 22:56
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 24, 2025
@OddBloke OddBloke requested a review from a team January 24, 2025 22:59
@imjasonh imjasonh added the staging-build If this label is set on a PR, it will be built by elastic-build in staging label Jan 25, 2025
@OddBloke OddBloke merged commit ec04869 into main Jan 27, 2025
22 checks passed
@OddBloke OddBloke deleted the wolfictl-440fe6ac-5c6d-4454-88ad-02cae7feec24 branch January 27, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package staging-build If this label is set on a PR, it will be built by elastic-build in staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants