Improve to show error page with reason after failed authentication #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6285 +/- ##
============================================
- Coverage 45.31% 45.30% -0.01%
+ Complexity 14544 14535 -9
============================================
Files 1656 1657 +1
Lines 104431 104454 +23
Branches 18372 18380 +8
============================================
+ Hits 47324 47326 +2
- Misses 50288 50308 +20
- Partials 6819 6820 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an authentication step fails, if authenticator has the retryAuthenticationEnabled as true, the same authenticator will be executed and prompted for a user input and the error reason is showed on that page.If retryAuthenticationEnabled is set to false, the user will be sent to the caller path of the application.
For push notification based authentication, during an authentication failure situation like user denying the request, the user has to be shown with an error page saying the relevant failure reason. Since, we show the errors when retrying the authenticator in our current implementation, this requirement cannot be fulfilled.
This PR will enable the authenticator to redirect to an error page when the authentication failure occurs.