Introduce push authenticator configuration support in my account #7350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7350 +/- ##
=======================================
Coverage 36.32% 36.32%
=======================================
Files 42 42
Lines 903 903
Branches 219 205 -14
=======================================
Hits 328 328
- Misses 529 575 +46
+ Partials 46 0 -46
Flags with carried forward coverage won't be shown. Click here to find out more. |
pavinduLakshan
force-pushed
the
push_auth_support_myaccount
branch
3 times, most recently
from
54be673 to
8ab52e3
Compare
pavinduLakshan
requested review from
NipuniBhagya,
jeradrutnam and
ZiyamSanthosh
pavinduLakshan
commented
Jan 22, 2025
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
pavinduLakshan
commented
Jan 22, 2025
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
pavinduLakshan
commented
Jan 22, 2025
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
| @@ -949,6 +949,61 @@ export const myAccount: MyAccountNS = { | |||
| }, | |||
| tryButton: "பழைய பாஸ்கி மூலம் முயற்சிக்கவும்" | |||
| }, | |||
| "pushAuthenticatorApp": { | |||
There was a problem hiding this comment.
@ZiyamSanthosh could you please review the tamil translations?
apps/myaccount/src/components/multi-factor-authentication/authenticators/fido-authenticator.tsx
Outdated
Show resolved
Hide resolved
.../myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.scss
Outdated
Show resolved
Hide resolved
apps/myaccount/src/components/multi-factor-authentication/authenticators/push-authenticator.tsx
Show resolved
Hide resolved
apps/myaccount/src/components/multi-factor-authentication/multi-factor-authentication.tsx
Show resolved
Hide resolved
pavinduLakshan
force-pushed
the
push_auth_support_myaccount
branch
from
b410fc3 to
e490ba8
Compare
NipuniBhagya
approved these changes
Jan 23, 2025
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks