Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
VajiraPrabuddhaka committed Oct 20, 2024
1 parent ddca93c commit a6c226b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions adapter/pkg/messaging/azure_connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,12 @@ func RetrieveSubscriptionMetadataForTopic(connectionString string, topicName str
logger.LoggerMsg.Errorf("Error occurred while trying to create ASB admin client using the connection url %s", connectionString)
return nil, clientErr
}
// Todo (vajira) : move this comment to parent method

// we are creating a unique subscription for each adapter starts. Unused subscriptions will be deleted after
// idle for three days

// in ASB, subscription names can contain letters, numbers, periods (.), hyphens (-), and
// underscores (_), up to 50 characters. Subscription names are also case-insensitive.

subscriptionName := fmt.Sprintf("%s_%s_sub", componentName, uuid.New().String())
_, err := adminClient.CreateSubscription(ctx, topicName, subscriptionName, &admin.CreateSubscriptionOptions{
Properties: opts,
Expand Down

0 comments on commit a6c226b

Please sign in to comment.