Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxdp: Doc adaptation for XSk umem opts-creation #453

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tacslon
Copy link
Contributor

@tacslon tacslon commented Nov 18, 2024

Edit documentation for creating XSk umem by opts, with minor format fix.
This is a follow-up to the previous work PR#443

@tacslon tacslon force-pushed the feat/opts-umem branch 2 times, most recently from 862c76c to d94c844 Compare November 21, 2024 07:18
Edit documentation for creating XSk umem by opts, with minor format fix.

Signed-off-by: Muyang Tian <[email protected]>
@tacslon tacslon changed the title libxdp: Doc and test adaptation for XSk umem opts-creation libxdp: Doc adaptation for XSk umem opts-creation Nov 21, 2024
@tacslon
Copy link
Contributor Author

tacslon commented Nov 21, 2024

This is to mark things for deprecation of old interfaces xsk_umem__create() and xsk_umem__create_with_fd().
Besides, how to deal with the existing selftest codes? IMO, use the new interface xsk_umem__create_opts() to replace the old interfaces may be a practical approach, WDYT? @tohojo @magnus-karlsson

@tohojo
Copy link
Member

tohojo commented Nov 29, 2024

Yeah, I'm OK with updating the selftests to use the new interface.

@tohojo tohojo merged commit 5ddccf5 into xdp-project:master Dec 9, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants