improve portability #457
Merged
improve portability #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing, PTAL |
rbgarga
force-pushed
the
improve-portability
branch
4 times, most recently
from
aa93a19 to
b684c78
Compare
|
@tohojo one test failed in one env, is it possible to try just that again? I wonder if it's related to the proposed change |
tohojo
reviewed
Dec 11, 2024
BSD grep has no -P parameter, replace it by a sed pattern that works both on GNU and BSDs. Signed-off-by: Renato Botelho do Couto <[email protected]>
BSD sed fails with "extra characters at the end of p command" error without the semicolon after p command while GNU sed works both ways. Signed-off-by: Renato Botelho do Couto <[email protected]>
xdp_multiprog__dispatcher() was removed by f0a2055 Signed-off-by: Renato Botelho do Couto <[email protected]>
Use compiler to link. While here, retire LD from configure since this is not used anymore Signed-off-by: Renato Botelho do Couto <[email protected]>
rbgarga
force-pushed
the
improve-portability
branch
from
b684c78 to
eaf1ed4
Compare
tohojo
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes intended