Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and small fixes #49

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

williamthome
Copy link
Contributor

This PR:

  • Removes trailing whitespaces and extra ending new lines;
  • Removes non-used headers;
  • Try to fix the ex_doc warning:

===> warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell) or set the ELIXIR_ERL_OPTIONS="+fnu" environment variable

  • Fix float warnings

Warning: matching on the float 0.0 will no longer also match -0.0 in OTP 27. If you specifically intend to match 0.0 alone, write +0.0 instead.

  • Use -type and -spec attributes instead of defining them in docs.

@mworrell mworrell self-assigned this Apr 26, 2024
@mworrell mworrell merged commit 845bd16 into zotonic:master Apr 26, 2024
3 checks passed
@mworrell
Copy link
Member

Merged!

And big thanks!

@williamthome williamthome deleted the refactor/cleanup branch April 26, 2024 10:54
@mworrell
Copy link
Member

Released 2.9.0 and upgraded zotonic master.

@williamthome
Copy link
Contributor Author

Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants