Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem where having duplicated blocks could result in endless recursion #55

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mworrell
Copy link
Member

If a nested block was called the same as an outer block then rendering the template would result in endless recursion.

Fixed by returning an error if a block contains multiple declarations of the same block name.

@mworrell mworrell requested a review from mmzeeman December 13, 2024 10:50
Copy link
Member

@mmzeeman mmzeeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice... a bug fix, before I even had the time to report an issue.

@mworrell mworrell merged commit 2a05c59 into master Dec 13, 2024
3 checks passed
@mworrell mworrell deleted the duplicate_block branch December 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants