-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade fuel-core
to 0.41.0
#3590
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Asset related functionality is partially implemented: |
@@ -82,7 +82,7 @@ describe('ExampleContract', () => { | |||
() => contractInstance.functions.return_input(1337).simulate(), | |||
new FuelError( | |||
ErrorCode.NOT_ENOUGH_FUNDS, | |||
`The account(s) sending the transaction don't have enough funds to cover the transaction.` | |||
`Insufficient funds or too many small value coins. Consider combining UTXOs.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm maybe we improve our error docs for this and link it in the message? We should probably offer a way for them to work out whether it's insufficient balance or too many coins.
@@ -753,6 +789,7 @@ export default class Provider { | |||
nodeVersion: nodeInfo.nodeVersion, | |||
utxoValidation: nodeInfo.utxoValidation, | |||
vmBacktrace: nodeInfo.vmBacktrace, | |||
// TODO: should we add `maxGas` and `txPoolStats` to the NodeInfo type? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2,25 +2,17 @@ import { ErrorCode, FuelError } from '@fuel-ts/errors'; | |||
import type { GraphQLError } from 'graphql'; | |||
|
|||
export enum GqlErrorMessage { | |||
NOT_ENOUGH_COINS = 'not enough coins to fit the target', | |||
MAX_COINS_REACHED = 'max number of coins is reached while trying to fit the target', | |||
NOT_ENOUGH_COINS_MAX_COINS = 'the target cannot be met due to no coins available or exceeding the 255 coin limit.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought 255 was configured on chain? Could this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct: 1321c22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely work @Torres-ssf 🚀
- Will will phase out the feature flags, as all the node upgrade to the latest version?
- With regards to the policy expiration, did we considered the resource cache for the UXTO's with a transaction using the expiration?
"@fuel-ts/account": patch | ||
"@fuel-ts/program": patch | ||
"@fuel-ts/recipes": patch | ||
"@fuel-ts/errors": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@fuel-ts/errors": patch | |
"@fuel-ts/errors": patch | |
"@fuel-ts/contract": patch |
@@ -753,6 +789,7 @@ export default class Provider { | |||
nodeVersion: nodeInfo.nodeVersion, | |||
utxoValidation: nodeInfo.utxoValidation, | |||
vmBacktrace: nodeInfo.vmBacktrace, | |||
// TODO: should we add `maxGas` and `txPoolStats` to the NodeInfo type? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this one for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -468,6 +479,7 @@ type GasCosts { | |||
wqmm: U64! | |||
xor: U64! | |||
xori: U64! | |||
ecop: U64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be adding this to our chain config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worthwhile testing the feature flags for:
balancePagination
amount128
* @param height - The height of the block to fetch. | ||
* @returns The compressed block if available, otherwise `null`. | ||
*/ | ||
async daCompressedBlock(height: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a tests around this functionality?
@@ -492,6 +504,7 @@ type GasCosts { | |||
smo: DependentCost! | |||
srwq: DependentCost! | |||
swwq: DependentCost! | |||
epar: DependentCost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be adding this to our chain config?
name: "Release PR to npm" | ||
runs-on: ubuntu-latest | ||
# comment out if:false to enable release PR to npm | ||
if: false | ||
# if: false | ||
permissions: write-all | ||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to uncomment the PR release line
Coverage Report:
Changed Files:
|
fuel-core
to0.41.0
#3588getBalances
#2748Release notes
In this release, we:
fuel-core
to0.41.0
Summary
GraphQL
amount128
to the responses of thegetBalance
andgetBalances
queries.assetDetails
query.SubId
.U128
.nodeInfoFragment
with newNodeInfo
fields (if needed).daCompressedBlock
query (if needed).Transaction
expiration
.Provider
getBalances
method.amount128
in both thegetBalance
andgetBalances
methods.excludedIds
parameter ingetResourcesToSpend
does not exceed the maximum number of inputs.getMessageProof
method to conform with the updatedMessageProof
type, which now requires a non-optional response.getAssetDetails
method.Docs
expiration
Breaking Changes
Because of the latest
fuel-core
changes, TS SDK does not throw the following error messages anymore:Checklist