[16.0] base_tier_validation: migration to 16 #540

bizzappdev · 2022-10-19T04:53:35Z

No description provided.

celm1990 · 2022-10-22T15:56:33Z

Any plan to improve performance??
please see #496

bizzappdev · 2022-10-23T13:33:57Z

Any plan to improve performance?? please see #496

Not in this MR.
Prio is the Migration first and then might be new MR for improvement of performance.

…on and validate if possible.

…ation records

* able to restart validation * sudo() not needed anymore

and reject can be hidden according to this computed field.

… and who asks for reviews in new fields 'done_by' and 'requested_by'.

fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu

…reviews' name and state correctly translated.

* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.

Currently translated at 100.0% (59 of 59 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/es/

StefanRijnhart · 2022-11-23T12:16:12Z

Please check the js linting

 error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

bizzappdev · 2022-11-23T12:48:56Z

Please check the js linting

 error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

I really do not have much idea about how to fix this. as in the entire odoo also they have imported like this only. as some suggestions are changing .eslintrc file. but that will be needed at 16.0 level.

base_tier_validation/views/res_config_settings_views.xml

StefanRijnhart · 2022-11-23T16:04:31Z

I really do not have much idea about how to fix this. as in the entire odoo also they have imported like this only. as some suggestions are changing .eslintrc file. but that will be needed at 16.0 level.

You can fix the errors by renaming the .js files to .esm.js files as mentioned in the 15.0 migration issue (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#tasks-to-do-in-the-migration). This will trigger further eslint messages that need to be followed up.

StefanRijnhart

Thanks for the huge work migrating this module and all its javascript! I tested the module successfully. The code still needs some work on the JS linting.

rven · 2022-11-29T07:11:11Z

``> Thanks for the huge work migrating this module and all its javascript! I tested the module successfully. The code still needs some work on the JS linting.

@StefanRijnhart
We discovered the same problem with the linting

I think the solution for the JS linting is the following:

parserOptions:
  ecmaVersion: 2019

overrides:
  - files:
      - "**/*.esm.js"
    parserOptions:
      sourceType: module

Should be adapted to

parserOptions:
  ecmaVersion: 2019
  sourceType: module

overrides:
  - files:
      - "**/*.esm.js"
    parserOptions:
      sourceType: module

After this change, the linting error will dissapear.

pedrobaeza · 2022-11-29T07:24:08Z

JS files should be renamed to .esm.js if they use the new ES6 syntax.

bizzappdev · 2022-12-06T09:38:18Z

Pre-commits are fixed. you can review it again.
code coverage is already more than 90%. should we increase the coverage?
@StefanRijnhart

StefanRijnhart · 2022-12-06T10:29:44Z

Thanks for the js updates! Looking good. Please check my version number comment. It's always good to improve coverage, but it's going to be hard to make that 96% mark. I had a look at what's still missing coverage, and I don't see anything critical.

StefanRijnhart

Thanks! Tested + code reviewed.

StefanRijnhart · 2022-12-06T13:05:18Z

/ocabot migration base_tier_validation

alan196

Tested functionally 👍

alan196 · 2022-12-23T15:47:34Z

I tested the module in a custom model, and I get an issue when I try to click on the notification in the tray menu.

It looks that is an issue of Odoo, I made the following PR odoo/odoo#108609 to fix this issue.

I post this in case you face the same issue 😄

dreispt · 2022-12-30T18:26:04Z

/ocabot merge nobump

OCA-git-bot · 2022-12-30T18:26:11Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-540-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2022-12-30T18:31:08Z

Congratulations, your PR was merged at 0b6c4e4. Thanks a lot for contributing to OCA. ❤️

bizzappdev force-pushed the 16.0-mig-base_tier_validation branch from 525a7a9 to ae420e4 Compare November 1, 2022 09:16

LoisRForgeFlow and others added 27 commits November 1, 2022 14:52

[9.0][ADD] base_tier_validation

6cc10ab

fix: blocking unneded records

65db709

[9.0][IMP] base_tier_validation: tries automatically request validati…

d9b2978

…on and validate if possible.

[9.0][IMP] base_tier_validation: filter out reviews not pending

f554665

make possible to filter by validated records

34d1b3a

allow to add exceptions for fields that can be written on under valid…

763e4de

…ation records

[9.0][IMP] base_tier_validation:

03cfe20

* able to restart validation * sudo() not needed anymore

[10.0][MIG] base_tier_validation

1ea20ea

[11.0][MIG] base_tier_validation

c0bf455

[11.0][IMP] base_tier_validation: add tests

8685d01

add 'can_review' to tier.validation so that the buttons approve

7d90fa3

and reject can be hidden according to this computed field.

[11.0][IMP] base_tier_validation: enhance views and register who does…

f583e60

… and who asks for reviews in new fields 'done_by' and 'requested_by'.

[11.0][FIX] base_tier_validation

1445dd7

Add name attribute to filter

8318d84

[MIG] base_tier_validation: Migration to 12.0

aca328d

[ADD] icon.png

86b1ae6

[IMP] base_tier_validation: Pass parameters as functions

91cba6c

[IMP] base_tier_validation: Add a chatter message if the model has it

f1547aa

[11.0][FIX] base_tier_validation: make name translatable and display …

441a64e

…reviews' name and state correctly translated.

[11.0][UPD] base_tier_validation: roadmap.

405cbfc

* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.

[12.0][MIG] base_tier_validation: adapt systray to v12.

63ba6ac

Added translation using Weblate (Spanish)

6f86dee

Translated using Weblate (Spanish)

a7d1006

Currently translated at 100.0% (59 of 59 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/es/

[12.0][FIX] dropdown style width and position

f0a19d2

[12.0][IMP] base_tier_validation module

4150c49

[FIX] base_tier_validation : singleton error

bd88b25

StefanRijnhart reviewed Nov 23, 2022

View reviewed changes

base_tier_validation/views/res_config_settings_views.xml Show resolved Hide resolved

StefanRijnhart requested changes Nov 23, 2022

View reviewed changes

bizzappdev force-pushed the 16.0-mig-base_tier_validation branch from 8c6ed64 to 1347ee4 Compare December 6, 2022 09:28

bizzappdev mentioned this pull request Dec 6, 2022

[MIG][16.0] sale_tier_validation: migration to 16 OCA/sale-workflow#2294

Merged

[MIG]: base_tier_validation: Migration to 16

145c570

bizzappdev force-pushed the 16.0-mig-base_tier_validation branch from 1347ee4 to 145c570 Compare December 6, 2022 10:39

StefanRijnhart approved these changes Dec 6, 2022

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Dec 6, 2022

OCA-git-bot mentioned this pull request Dec 6, 2022

Migration to version 16.0 #534

Open

27 tasks

This was referenced Dec 6, 2022

[MIG] purchase_request_tier_validation: Migration to 16.0 OCA/purchase-workflow#1671

Merged

[MIG] purchase_tier_validation: Migration to 16.0 OCA/purchase-workflow#1669

Merged

alan196 approved these changes Dec 20, 2022

View reviewed changes

OCA-git-bot added the approved label Dec 20, 2022

OCA-git-bot added the bot is merging ⏳ label Dec 30, 2022

OCA-git-bot merged commit fae2da3 into OCA:16.0 Dec 30, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 30, 2022

dreispt mentioned this pull request Jun 29, 2023

[16.0][MIG] partner_tier_validation OCA/partner-contact#1488

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] base_tier_validation: migration to 16 #540

[16.0] base_tier_validation: migration to 16 #540

bizzappdev commented Oct 19, 2022

celm1990 commented Oct 22, 2022

bizzappdev commented Oct 23, 2022

StefanRijnhart commented Nov 23, 2022

bizzappdev commented Nov 23, 2022 •

edited

Loading

StefanRijnhart commented Nov 23, 2022

StefanRijnhart left a comment •

edited

Loading

rven commented Nov 29, 2022

pedrobaeza commented Nov 29, 2022

bizzappdev commented Dec 6, 2022

StefanRijnhart commented Dec 6, 2022

StefanRijnhart left a comment

StefanRijnhart commented Dec 6, 2022

alan196 left a comment

alan196 commented Dec 23, 2022

dreispt commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

[16.0] base_tier_validation: migration to 16 #540

[16.0] base_tier_validation: migration to 16 #540

Conversation

bizzappdev commented Oct 19, 2022

celm1990 commented Oct 22, 2022

bizzappdev commented Oct 23, 2022

StefanRijnhart commented Nov 23, 2022

bizzappdev commented Nov 23, 2022 • edited Loading

StefanRijnhart commented Nov 23, 2022

StefanRijnhart left a comment • edited Loading

Choose a reason for hiding this comment

rven commented Nov 29, 2022

pedrobaeza commented Nov 29, 2022

bizzappdev commented Dec 6, 2022

StefanRijnhart commented Dec 6, 2022

StefanRijnhart left a comment

Choose a reason for hiding this comment

StefanRijnhart commented Dec 6, 2022

alan196 left a comment

Choose a reason for hiding this comment

alan196 commented Dec 23, 2022

dreispt commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

bizzappdev commented Nov 23, 2022 •

edited

Loading

StefanRijnhart left a comment •

edited

Loading