MINOR: add removed controller metrics to zk2kraft #18654
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <[email protected]>
3 tasks
chia7712
reviewed
Jan 21, 2025
docs/zk2kraft.html
Outdated
| @@ -164,5 +164,16 @@ <h5 class="anchor-heading">Removal metrics</h5> | |||
| In Kraft mode, Zookeeper is not used, so the metrics is removed. | |||
| </p> | |||
| </li> | |||
| <li> | |||
| <p> | |||
| Remove the controller metrics. In Kraft mode, there is no broker which is elected as controller to communicate with ZooKeeper. | |||
There was a problem hiding this comment.
This description is not accurate. We don't need to explain the all usage of those metrics, since that is not the purpose of this docs. Maybe we can add those metrics to the line#161? WDYT?
There was a problem hiding this comment.
Agree. I think we should also update description at line#158.
Signed-off-by: PoAn Yang <[email protected]>
chia7712
reviewed
Jan 21, 2025
| </p> | ||
| <ul> | ||
| <li><code>kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs</code></li> | ||
| <li><code>kafka.controller:type=ControllerChannelManager</code></li> |
There was a problem hiding this comment.
Should we list complete metrics attributes? It would be useful to search specific metrics. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #18573 (review)
Add following removed controller metrics to
zk2kraft.html.Committer Checklist (excluded from commit message)