Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add removed controller metrics to zk2kraft #18654

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

MINOR: add removed controller metrics to zk2kraft #18654

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0851a3
MINOR: add removed controller metrics to zk2kraft
FrankYang0529 Jan 21, 2025
d408a10
address comment
FrankYang0529 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/zk2kraft.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,16 @@ <h5 class="anchor-heading">Removal metrics</h5>
In Kraft mode, Zookeeper is not used, so the metrics is removed.
</p>
</li>
<li>
<p>
Remove the controller metrics. In Kraft mode, there is no broker which is elected as controller to communicate with ZooKeeper.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not accurate. We don't need to explain the all usage of those metrics, since that is not the purpose of this docs. Maybe we can add those metrics to the line#161? WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think we should also update description at line#158.

</p>
<ul>
<li><code>kafka.controller:type=ControllerChannelManager</code></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list complete metrics attributes? It would be useful to search specific metrics. WDYT?

<li><code>kafka.controller:type=ControllerEventManager</code></li>
<li><code>kafka.controller:type=KafkaController</code></li>
<li><code>kafka.controller:type=ControllerStats</code></li>
</ul>
</li>
</ul>
</div>
Loading