-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding a delete_event #340
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 96.18% 95.85% -0.33%
==========================================
Files 69 70 +1
Lines 7417 7504 +87
==========================================
+ Hits 7134 7193 +59
- Misses 205 233 +28
Partials 78 78
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be a new field in library.Repo
or database.Repo
— only in library.Events
should there be a new action set for delete events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, do we want to add delete
here as well:
Lines 147 to 163 in 26e54c8
for _, e := range rules.Event { | |
switch e { | |
// backwards compatibility | |
// pull_request = pull_request:opened + pull_request:synchronize + pull_request:reopened | |
// comment = comment:created + comment:edited | |
case constants.EventPull: | |
events = append(events, | |
constants.EventPull+":"+constants.ActionOpened, | |
constants.EventPull+":"+constants.ActionSynchronize, | |
constants.EventPull+":"+constants.ActionReopened) | |
case constants.EventComment: | |
events = append(events, | |
constants.EventComment+":"+constants.ActionCreated, | |
constants.EventComment+":"+constants.ActionEdited) | |
default: | |
events = append(events, e) | |
} |
delete
it will add both actions for you? not saying we have to, just asking to get thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This code enables the delete webhook in Vela, so users can select to trigger a build when a branch or tag are deleted.