Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle wabt objects into libHalide #5283

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Bundle wabt objects into libHalide #5283

merged 1 commit into from
Sep 23, 2020

Conversation

alexreinking
Copy link
Member

Only affects Halide 11+. No more need to package libwabt.a, just includes its objects into libHalide.a

@alexreinking
Copy link
Member Author

alexreinking commented Sep 18, 2020 •
edited
Loading

This would be another good candidate PR for the cmake label I described in halide/build_bot#92

@steven-johnson steven-johnson added the backport me This change should be backported to release versions label Sep 18, 2020
@alexreinking
Copy link
Member Author

We shouldn't unconditionally use $<TARGET_OBJECTS>. We should only do that when building static Halide. We should just link normally/privately to wabt when building shared Halide to allow the linker to drop unnecessary symbols.

steven-johnson
steven-johnson approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexreinking
Copy link
Member Author

alexreinking commented Sep 20, 2020 •
edited
Loading

Also, no need to backport since Halide 10 uses LLVM 10 which doesn't support WebAssembly?

@steven-johnson steven-johnson removed the backport me This change should be backported to release versions label Sep 21, 2020
@steven-johnson
Copy link
Contributor

Is this ready to land?

@steven-johnson steven-johnson mentioned this pull request Sep 23, 2020
Closed
@steven-johnson steven-johnson merged commit ee2cb21 into master Sep 23, 2020
@steven-johnson steven-johnson deleted the wabt-bundle branch September 23, 2020 21:47
@alexreinking alexreinking added this to the v11.0.0 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexreinking @steven-johnson