Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write pcap header to the named pipe. #12

Closed
wants to merge 1 commit into from

Conversation

bserdar
Copy link
Contributor

@bserdar bserdar commented Dec 8, 2023

This is to make worker start reading packets from an existing pcap file.

@mertyildiran
Copy link
Member

The PCAP reader of sniffer container which opens the named pipe tls.pcap requires the file header to determine the first layer of the packets. The two containers start/restart together unless manually intervened and it should be fail safe. The file must be a valid PCAP file for the sake of clean implementation and debuggability.

@alongir
Copy link
Member

alongir commented Jan 9, 2024

Not sure it's connected. However, traffic that was successfully captured by the Tracer is not read by the Worker.
@iluxa is on it: #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants