Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write pcap header to the named pipe. #12

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packet_sorter.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"syscall"

"github.com/kubeshark/gopacket"
"github.com/kubeshark/gopacket/layers"
"github.com/kubeshark/gopacket/pcapgo"
"github.com/kubeshark/tracer/misc"
"github.com/rs/zerolog/log"
Expand Down Expand Up @@ -66,10 +65,8 @@ func (s *PacketSorter) initMasterPcap() {
file: file,
writer: writer,
}
err = writer.WriteFileHeader(uint32(misc.Snaplen), layers.LinkTypeEthernet)
if err != nil {
log.Error().Err(err).Msg("While writing the PCAP header:")
}
// Do not write PCAP header. This is a named pipe, and a worker
// might be waiting to read from it already
}
} else {
file, err = os.OpenFile(misc.GetMasterPcapPath(), os.O_APPEND|os.O_WRONLY, os.ModeNamedPipe)
Expand Down
Loading