-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 2FAST2Q module #7318
base: master
Are you sure you want to change the base?
Added 2FAST2Q module #7318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason it isn't called 2fastq? Did something fall over because of the number at the start?
The reason I am "filling" it as fast2q is because the PyPI module is called fast2q (numbers at the start are a no go naming wise). The same for nextflow processes I find out? So, despite the tool being published as 2FAST2Q, internally I am keeping it as fast2q, in line with nomenclature. |
Ok, that's fine, if it can't be |
This is apparently failing on the tests. @SPPearce you are more experienced. Could you provide some insight to what I need to change, please? Cheers! |
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
…just as a way to check if it is working. The test data I was using from NF-core has the wrong input file format.
…just as a way to check if it is working. The test data I was using from NF-core has the wrong input file format.
…just as a way to check if it is working. The test data I was using from NF-core has the wrong input file format.
…just as a way to check if it is working. The test data I was using from NF-core has the wrong input file format.
@SPPearce The test errors I am getting now are due to some issue loading the right data. I am trying to use 2 files from here: https://github.com/nf-core/test-datasets/tree/crisprseq/testdata but the errors I am getting from the 2FAST2Q are related with the the files not being correct (either the wrong extention, or the wrong format). I know the files are right and the programs works with them "outside" nextflow, so, could it be some issue loading the right data from modules_testdata_base_path on nextflow.config? |
You shouldn't be trying to set modules_testdata_base_path here, that is globally set. |
Co-authored-by: Simon Pearce <[email protected]>
@SPPearce seems to be ready for one last review and approval. Sorry for having spammed too much! |
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
@SPPearce I made all tests snapshot comparisons and they are working locally. Everything seems ok. Any more comments? |
No description provided.