Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

418 update cellbender and add gpu support #419

Merged
merged 5 commits into from
Jan 15, 2025
Merged

418 update cellbender and add gpu support #419

merged 5 commits into from
Jan 15, 2025

Conversation

fmalmeida
Copy link
Contributor

@fmalmeida fmalmeida commented Jan 13, 2025 •
edited
Loading

PR checklist

  • Updating cellbender module version and adding gpu configuration
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • CHANGELOG.md is updated.

@fmalmeida fmalmeida requested a review from grst January 13, 2025 11:28
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 29d8ed7

+| ✅ 215 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2025-01-15 07:07:57

grst
grst approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grst grst enabled auto-merge January 15, 2025 07:06
@grst grst merged commit 52bbe2f into dev Jan 15, 2025
13 checks passed
@grst grst deleted the 418-update-cellbender-and-add-gpu-support branch January 15, 2025 07:08
@fmalmeida fmalmeida linked an issue Jan 15, 2025 that may be closed by this pull request
Update cellbender and add GPU support #418
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cellbender and add GPU support
3 participants
@fmalmeida @nf-core-bot @grst