Fix #267, explain why we are not using JSON Path or JSON Pointer #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-pi
reviewed
Jan 14, 2025
Co-authored-by: Brian Campbell <[email protected]>
bc-pi
approved these changes
Jan 14, 2025
bc-pi
reviewed
Jan 14, 2025
| @@ -1001,6 +1001,13 @@ selectively disclosable claims were disclosed to a Verifier. That means that a | |||
| consuming application which does not have access to all disclosures may not be | |||
| able to identify the claim which is being addressed. | |||
|
|
|||
| Note: This specification intentionally does not use JSON Pointer [@RFC6901] for | |||
There was a problem hiding this comment.
let's be explicit about the "?"ness
Suggested change
| Note: This specification intentionally does not use JSON Pointer [@RFC6901] for | |
| Note: This specification intentionally does not use JSON Pointer [@?RFC6901] for |
timcappalli
reviewed
Jan 19, 2025
Comment on lines
+1007
to
+1009
| that introduces a considerable complexity and brings in a lot of features that | ||
| are not needed for the use case of selecting claims in a credential. There are | ||
| also security concerns with some implementations. |
There was a problem hiding this comment.
editorial nit
Suggested change
| that introduces a considerable complexity and brings in a lot of features that | |
| are not needed for the use case of selecting claims in a credential. There are | |
| also security concerns with some implementations. | |
| that introduces a considerable complexity and brings in many features which | |
| are not needed for the use case of selecting claims in a credential. There are | |
| also security concerns with some implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #267