Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #267, explain why we are not using JSON Path or JSON Pointer #295

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix #267, explain why we are not using JSON Path or JSON Pointer #295

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ccddc7
Fix #267, explain why we are not using JSON Path or JSON Pointer
danielfett Jan 13, 2025
0b08e0d
fix reference
danielfett Jan 13, 2025
fcaffaa
fix reference now?
danielfett Jan 13, 2025
3f56fd2
Update draft-ietf-oauth-sd-jwt-vc.md
danielfett Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions draft-ietf-oauth-sd-jwt-vc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,13 @@ selectively disclosable claims were disclosed to a Verifier. That means that a
consuming application which does not have access to all disclosures may not be
able to identify the claim which is being addressed.

Note: This specification intentionally does not use JSON Pointer [@RFC6901] for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's be explicit about the "?"ness

Suggested change
Note: This specification intentionally does not use JSON Pointer [@RFC6901] for
Note: This specification intentionally does not use JSON Pointer [@?RFC6901] for

selecting claims, as JSON Pointer requires string parsing and does not support
wildcard selection of array elements. It does not use JSON Path [@?I-D.goessner-dispatch-jsonpath] as
that introduces a considerable complexity and brings in a lot of features that
are not needed for the use case of selecting claims in a credential. There are
also security concerns with some implementations.
Comment on lines +1007 to +1009
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editorial nit

Suggested change
that introduces a considerable complexity and brings in a lot of features that
are not needed for the use case of selecting claims in a credential. There are
also security concerns with some implementations.
that introduces a considerable complexity and brings in many features which
are not needed for the use case of selecting claims in a credential. There are
also security concerns with some implementations.


## Claim Display Metadata {#claim-display-metadata}

The `display` property is an array containing display information for the
Expand Down Expand Up @@ -1315,6 +1322,7 @@ recommendations in (#robust-retrieval) apply.
</author>
</front>
</reference>

{backmatter}

# IANA Considerations
Expand Down Expand Up @@ -1573,6 +1581,7 @@ for their contributions (some of which substantial) to this draft and to the ini
-09

* Use SD-JWT KB in place of SD-JWT with Key Binding JWT
* Document reasons for not using JSON Pointer or JSON Path (Issue #267)

-08

Expand Down
Loading