Define new WorkflowTemplates to allow partial builds and refactor existing WorkflowTemplates and Manifests to deploy Argo Workflows #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleskandro
changed the title
| set -ex | ||
| echo "Preparing memoization params" | ||
| git_uri=$(oc get bc {{inputs.parameters.build-config-name}} -o jsonpath='{.spec.source.git.uri}') | ||
| git_revision=$(oc get bc {{inputs.parameters.build-config-name}} -o jsonpath='{.spec.source.git.ref}') |
There was a problem hiding this comment.
how do we deal with errors in oc commands/timeouts etc..?
There was a problem hiding this comment.
Hi @Prashanth684 it would fail for such issues. However, we never wait for long-runing executions (as in oc wait bc) to conclude because Argo Workflow has its own ways for doing it.
vrutkovs
reviewed
Oct 13, 2023
aleskandro
force-pushed
the
partial-builds
branch
2 times, most recently
from
94e9cae to
ea92b64
Compare
aleskandro
changed the title
aleskandro
force-pushed
the
partial-builds
branch
from
ea92b64 to
ee46a61
Compare
|
/hold splitting in more PRs to keep things cleaner. |
aleskandro
force-pushed
the
partial-builds
branch
2 times, most recently
from
3b90e5b to
6a62f78
Compare
Let's use overlays to define the common namespace. In future, this will be usefule to test changes in this repo by having manifests and runs in different namespaces.
- Define the mirror-and-customize workflow template - Define the mirror-and-rebuild-okd workflow template - Pivot the build-from-scratch workflow template to mirror-and-customize - Some images (ironic-related) are temporarily disabled in the mirror-and-rebuild-okd workflow template because they fail on arm64
The memoize feature does not support using configmaps in namespaces different from the one where argo workflows is deployed.
There is no way today for changing the OAuthClient redirectURIs given a resource created in the cluster while applying the kustomization. Creating a job with the proper permissions to patch the resource after the kustomization is applied.
aleskandro
force-pushed
the
partial-builds
branch
from
6a62f78 to
97c3bfc
Compare
aleskandro
changed the title
|
All is ready for further reviews or merge. |
vrutkovs
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Refines the Argo Workflows deployment manifests
Reorganizes the argo workflow templates, by defining:
Adds some doc around the Argo Workflows templates.
blocked by OCPBUGS-20474: Set ImportPolicy to PreserveOriginal to honor --keep-manifest-list when mirroring a payload to an image stream openshift/oc#1572
blocked by Workflows image images#15
blocked by Get the nmstate pinned package from kojihub when building on top of a CentOS base image openshift/machine-config-operator#3954
blocked by Adds replacements for 4.15, reset buildconfigs to track the default branches of components and minor fixes #60
related to adm release new with --mirror --from-image-stream should not require a public route for the internal registry openshift/oc#1580
Fixes #52
Related to #55, #56
cc @LorbusChris @vrutkovs