Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit test great again #38

Merged
merged 9 commits into from
Nov 26, 2024
Merged

Make unit test great again #38

merged 9 commits into from
Nov 26, 2024

Conversation

syjn99
Copy link
Collaborator

@syjn99 syjn99 commented Nov 25, 2024

Fix bunch of unit tests. This work is needed for adding CI check.

  • For most tests, they were broken because of few changes in parameters(e.g. increment...)
  • It seems some tests are failed, but in fact they have such log:
    -No pass/skip/fail event found for test
    • These tests are solved by adding a t.Log statement manually.
  • TestKeymanager_Sign was skipped for a while, but it was found that fixing some codes makes it work.
  • mainnet.ssz.snappy was changed thx to @gts2030.
  • TestDownloadBackwardsCompatibleCombined always fails if TestDownloadWeakSubjectivityCheckpoint evaluates first, so I changed their order (hacky 🫤)
  • Skipped pregen_test.go (b/c ssz files should be generated again for our new spec)
  • Deleted web3remotesigner_test.go

@syjn99 syjn99 self-assigned this Nov 25, 2024
@syjn99 syjn99 marked this pull request as ready for review November 25, 2024 12:06
@syjn99 syjn99 requested a review from a team as a code owner November 25, 2024 12:06
@overprotocol overprotocol deleted a comment from notion-workspace bot Nov 26, 2024
@sb-anderson
Copy link
Contributor

It looks like there are skipped tests for pre-generated SSZ files. Although it might not be critical, it’s something we should fix soon. Can we check this as a new issue to ensure it’s tracked?

@syjn99
Copy link
Collaborator Author

syjn99 commented Nov 26, 2024

@sb-anderson #40 will track those tests!

@sb-anderson sb-anderson merged commit c3de9d8 into master Nov 26, 2024
4 checks passed
@sb-anderson sb-anderson deleted the fix/unit-tests branch November 26, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants