Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar nav for Errors and Server Responses #9387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rachelwhitton
Copy link
Member

Summary

Multipage guide, Errors and Server Responses is nested too deep. This PR pulls the guide up a layer in the sidebar nav so we can see subpages too

Instead of:
Support > Troubleshooting > Timeouts and Errors > Errors and Server Responses

It's now:
Support > Troubleshooting > Errors and Server Responses

@rachelwhitton rachelwhitton requested a review from a team as a code owner January 23, 2025 21:05
@rachelwhitton rachelwhitton self-assigned this Jan 23, 2025
@rachelwhitton rachelwhitton added Site: Site Structure Issue or PR with the docs app stack and/or live site Type: Quick Fix Issues that should be resolvable in a small PR Site: Design Issues about the design of of the site, often regressions labels Jan 23, 2025
Comment on lines 37 to 40
simpleLink('/timeouts', 'Timeouts and Errors', [
simpleLink('/timeouts', 'Timeouts on Pantheon'),
getGuideDirectory('guides/errors-and-server-responses'),
simpleLink('/debug-connections', 'Debugging Connectivity Issues'),
]),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevector @jazzsequence Does this layer still make sense without the multipage guide nested in it? Should the last 2 left here be moved up a layer as well?

First image shows the layer still intact w/2 left in it
Screenshot 2025-01-23 at 2 57 12 PM

compared to this one, which moves the whole thing up a layer
Screenshot 2025-01-23 at 2 57 58 PM

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9387-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site: Design Issues about the design of of the site, often regressions Site: Site Structure Issue or PR with the docs app stack and/or live site Type: Quick Fix Issues that should be resolvable in a small PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant