Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar nav for Errors and Server Responses #9387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −5
Open

Fix sidebar nav for Errors and Server Responses #9387

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cac06f4
Move errors guide up one layer in submenu
rachelwhitton Jan 23, 2025
9ebc8df
Remove nested layer from support submenu
rachelwhitton Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/omniSidebarNav/submenus/support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ const support = () => {
]),
simpleLink('/timeouts', 'Timeouts and Errors', [
simpleLink('/timeouts', 'Timeouts on Pantheon'),
getGuideDirectory('guides/errors-and-server-responses'),
simpleLink('/debug-connections', 'Debugging Connectivity Issues'),
]),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevector @jazzsequence Does this layer still make sense without the multipage guide nested in it? Should the last 2 left here be moved up a layer as well?

First image shows the layer still intact w/2 left in it
Screenshot 2025-01-23 at 2 57 12 PM

compared to this one, which moves the whole thing up a layer
Screenshot 2025-01-23 at 2 57 58 PM

getGuideDirectory('guides/errors-and-server-responses'),
simpleLink('/mime-types', 'MIME Types'),
simpleLink('/resetting-passwords', 'Resetting Passwords'),
simpleLink('/local-dns-cache', 'Local DNS Cache'),
Expand Down
Loading