Make earnings list month entries collapseable and change default of it for newly added widget #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
("all", "none", "current month"). If a new widget is added, "current
month" is used as default, if the widget is "loaded" from a file
pre-configuration, "all" is used as default to keep the old behavior to
prevent existing dashboard designs to break
buchen
reviewed
May 25, 2024
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_cs.properties
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages.properties
Show resolved
Hide resolved
....portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/earnings/EarningsListWidget.java
Show resolved
Hide resolved
buchen
pushed a commit
that referenced
this pull request
May 25, 2024
Added the configuration of how many months should be shown with details
("all", "none", "current month").
Issue: #4030
Signed-off-by: Lothar Kimmeringer <[email protected]>
[removed isNewWidget property; removed duplicated message labels;
use adapter for mouse listener, rebased to master]
Signed-off-by: Andreas Buchen <[email protected]>
buchen
pushed a commit
that referenced
this pull request
May 25, 2024
buchen
added a commit
that referenced
this pull request
May 25, 2024
Used for the earnings list widget: If a new widget is added, "current month" is used as default, if the widget is "loaded" from a file pre-configuration, "all" is used as default to keep the old behavior to prevent existing dashboard designs to break Issue: #4030 Co-authored-by: Lothar Kimmeringer <[email protected]> Co-authored-by: Andreas Buchen <[email protected]>
|
I have adapted the pull request according to the comments and merged it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this change is a first step in the redesign of the earnings list widget as discussed in #4010. It makes month-entries "clickable" and leads to the collapse and expanse of the entries. This allows the widget to take up less space. I've also added a new configuration entry to control the default behavior (collapse all, expand current month, expand all). The deault behavior of newly added widget is "expand current month" that I regard as a useful default. If a widget has been added already, the previous "default" "expand all" is used.