Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --cgroup-manager cgroupfs for e2e PR check #635

Merged

Conversation

sutaakar
Copy link
Contributor

Issue link

What changes have been made

Current changes in NVidia GitHub image and codeflare-common caused issues in building CFO image in NVidia GitHub image. Adding --cgroup-manager cgroupfs helps avoiding the error.
Solution taken from containers/podman#6368 .

Verification steps

Tested in PR check #634

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar requested review from jiripetrlik and removed request for KPostOffice November 27, 2024 13:32
Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 390fb17 into project-codeflare:main Nov 27, 2024
6 checks passed
@sutaakar sutaakar deleted the fix-e2e-pr-check branch November 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants