Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --cgroup-manager cgroupfs for e2e PR check #635

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add --cgroup-manager cgroupfs for e2e PR check #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/e2e_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ jobs:
kind load image-archive cfo.tar --name cluster --verbosity 1000
make deploy -e IMG="${IMG}" -e ENV="e2e"
kubectl wait --timeout=120s --for=condition=Available=true deployment -n openshift-operators codeflare-operator-manager
env:
# cgroup-manager configuration is required for NVidia image used in e2e PR check
IMAGE_BUILD_FLAGS: '--cgroup-manager cgroupfs'

- name: Run e2e tests
run: |
Expand Down
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ endif

# Image URL to use all building/pushing image targets
IMG ?= ${IMAGE_TAG_BASE}:${VERSION}

# IMAGE_BUILD_FLAGS are the flags passed to the podman operator image build command
IMAGE_BUILD_FLAGS :=

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.24.2

Expand Down Expand Up @@ -184,7 +188,7 @@ run: manifests fmt vet ## Run a controller from your host.

.PHONY: image-build
image-build: test-unit ## Build container image with the manager.
podman build -t ${IMG} .
podman $(IMAGE_BUILD_FLAGS) build -t ${IMG} .

.PHONY: image-push
image-push: image-build ## Push container image with the manager.
Expand Down