[c++] Update minimum macOS deployment target #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
🚢 once CI is ☘️ -- thank you @XanthosXanthopoulos for sticking with this!!! :)
Comment on lines
+116
to
+118
| # Set minimum macOS version to enable certain C++20 features | ||
| # set(CMAKE_OSX_DEPLOYMENT_TARGET 13.3) | ||
|
|
There was a problem hiding this comment.
Does this comment need to be here?
There was a problem hiding this comment.
I would like to enable it eventually (that's why I have it - as a reminder) but I do not know what effect it would have on conda build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3534 +/- ##
==========================================
+ Coverage 86.25% 86.30% +0.04%
==========================================
Files 55 55
Lines 6359 6359
==========================================
+ Hits 5485 5488 +3
+ Misses 874 871 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jdblischak
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the C++20 migration to work we need to increase the minimum macOS deployment target to 13.3 to have support for floating-point formatter.
#3154
[sc-57301]