Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies for Flutter 3.27 #1649

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Upgrade dependencies for Flutter 3.27 #1649

merged 1 commit into from
Dec 30, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR upgrades our packages and dependencies to be compatible with Flutter 3.27! To read more about the changes in 3.27, see https://medium.com/flutter/whats-new-in-flutter-3-27-28341129570c

One notable change here is that Flutter 3.27 now uses Impeller as the default rendering engine on Android, which should hopefully improve the overall smoothness and experience on Android devices!

I'll also have a follow-up PR to update our CI to use 3.27 once this is merged in

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member Author

I'll go ahead and merge this in as it's a blocker (I'm unable to run builds locally since I upgraded to 3.27). Do let me know if there are any issues that come up from this though!

@hjiangsu hjiangsu merged commit fd2fd2c into develop Dec 30, 2024
1 check passed
@hjiangsu hjiangsu deleted the chore/flutter-3.27 branch December 30, 2024 08:28
@micahmo
Copy link
Member

micahmo commented Dec 30, 2024

Flutter 3.27 now uses Impeller as the default rendering engine on Android

Nice!!

@micahmo
Copy link
Member

micahmo commented Dec 30, 2024

Hey @hjiangsu just a heads up that I noticed a small UI issue which I assume is related to this change. Some places with icon buttons seem have much smaller icons now, such as...

  • the top row of actions in both the post and comment bottom sheet
  • the star button for communities in the sidebar

That's all I've noticed so far but I'll update if I see any thing else.

I haven't looked at the code yet, but I'm guessing these are all IconButton widgets with a custom size.

@micahmo
Copy link
Member

micahmo commented Dec 30, 2024

Hey @hjiangsu just a heads up that I noticed a small UI issue which I assume is related to this change. Some places with icon buttons seem have much smaller icons now, such as...

  • the top row of actions in both the post and comment bottom sheet
  • the star button for communities in the sidebar

That's all I've noticed so far but I'll update if I see anything else.

I haven't looked at the code yet, but I'm guessing these are all IconButton widgets with a custom size.

@micahmo micahmo mentioned this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants