Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbopack/napi): Flush optional task cache hit statistics upon completion of build #75122

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 20, 2025

cd ~/front/apps/next-site
rm -rf .next && NEXT_TURBOPACK_TASK_STATISTICS=~/build-stats.json TURBOPACK=1 TURBOPACK_BUILD=1 TURBOPACK_PERSISTENT_CACHE=0 /bin/time -v pnpm next build --experimental-build-mode=compile
jq 'to_entries | sort_by(.value.cache_hit, -.value.cache_miss) | from_entries' <build-stats.json >build-stats-sorted.json

Gives the following build-stats-sorted.json file: https://gist.github.com/bgw/cd3bafbbe08a428334ed9bec10885769

Closes PACK-3782

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 20, 2025
@ijjk
Copy link
Member

ijjk commented Jan 21, 2025

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
buildDuration 17.2s 15s N/A
buildDurationCached 14.2s 12s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +1.9 kB
nextStartRea..uration (ms) 413ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
index.html gzip 523 B 523 B
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 520 B N/A
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
middleware-b..fest.js gzip 669 B 664 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache
vercel/next.js canary vercel/next.js bgw/flush-build-cache-stats Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 74.3 kB 74.3 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 30bde63

@bgw bgw force-pushed the bgw/local-tasks-default branch from 88996ef to 533be5a Compare January 21, 2025 01:04
@bgw bgw force-pushed the bgw/flush-build-cache-stats branch from e937297 to 9ff3592 Compare January 21, 2025 01:05
@bgw bgw marked this pull request as ready for review January 21, 2025 01:05
@ijjk
Copy link
Member

ijjk commented Jan 21, 2025

Tests Passed

@bgw bgw force-pushed the bgw/local-tasks-default branch 2 times, most recently from a1d3b24 to 517946b Compare January 21, 2025 16:29
@bgw bgw force-pushed the bgw/flush-build-cache-stats branch from 9ff3592 to b368bc5 Compare January 21, 2025 16:29
@bgw bgw changed the base branch from bgw/local-tasks-default to graphite-base/75122 January 21, 2025 17:37
@bgw bgw force-pushed the bgw/flush-build-cache-stats branch from b368bc5 to 1e98cce Compare January 21, 2025 17:38
@bgw bgw force-pushed the graphite-base/75122 branch from 517946b to 165d25b Compare January 21, 2025 17:38
@bgw bgw changed the base branch from graphite-base/75122 to canary January 21, 2025 17:38
@bgw bgw force-pushed the bgw/flush-build-cache-stats branch from 1e98cce to 30bde63 Compare January 21, 2025 17:38
@bgw bgw merged commit f71af29 into canary Jan 22, 2025
131 checks passed
@bgw bgw deleted the bgw/flush-build-cache-stats branch January 22, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants