Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-7120] Move the server-side embedding logic to the server and host-controller modules #6308

Merged
merged 3 commits into from
Jan 21, 2025
Merged

[WFCORE-7120] Move the server-side embedding logic to the server and host-controller modules #6308

merged 3 commits into from
Jan 21, 2025

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry commented Dec 26, 2024 •
edited
Loading

@bstansberry bstansberry marked this pull request as ready for review December 27, 2024 13:50
@wildfly wildfly deleted a comment from wildfly-ci Jan 3, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 3, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 3, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 3, 2025
@bstansberry bstansberry requested a review from jamezp January 14, 2025 19:55
@wildfly wildfly deleted a comment from wildfly-ci Jan 14, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 14, 2025
@wildfly-ci
Copy link

Core -> Full Integration Build 14524 outcome was UNKNOWN using a merge of fe81914
Summary: Canceled (Error while applying patch; cannot find commit 43c8e50 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6308/merge branch was updated and the commit selected for the ... Build time: 00:00:21

jamezp
jamezp approved these changes Jan 20, 2025
View reviewed changes
...ler/src/main/java/org/jboss/as/host/controller/embedded/EmbeddedHostControllerBootstrap.java Outdated
import org.jboss.msc.service.ServiceContainer;
import org.jboss.msc.service.ServiceTarget;

/**
* Bootstrap of the Embedded HostController process.
* Embedded variant of {@link org.jboss.as.host.controller.HostControllerBootstrap}. TODO see if these can be unified.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but was this TODO resolved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamezp No, we still have duplication, hence that class.

IIRC the work I did on this got the embedded and non-embedded bootstrap code a bit more aligned, but there are still small differences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamezp I filed https://issues.redhat.com/browse/WFCORE-7143. I'll update the TODO here because this PR could use fresh CI anyway. But I'll make no change beyond a tweak to this comment, so no need for a re-review.

@wildfly-ci
Copy link

Core -> Full Integration Build 14546 outcome was UNKNOWN using a merge of 7b89469
Summary: Canceled (Tests passed: 867, ignored: 11; Step 5/6) Build time: 00:12:30

@wildfly-ci
Copy link

Core -> Full Integration Build 14241 outcome was UNKNOWN using a merge of 7b89469
Summary: Canceled (Tests passed: 169, ignored: 4; Step 5/6) Build time: 00:12:30

@bstansberry bstansberry merged commit f6f9260 into wildfly:main Jan 21, 2025
13 checks passed
@bstansberry bstansberry deleted the WFCORE-7120 branch January 21, 2025 14:39
@bstansberry
Copy link
Contributor Author

Thanks @jamezp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bstansberry @wildfly-ci @jamezp